I grew up watching war movies with my Grandpa (WWII Vet) and Uncle (Vietnam Vet) so many of them are great memories for me.
Some others not mentioned:
The Blue & The Gray
Glory
Gettysburg (spl)
The Patriot
Midway
Zulu
Rommel
Gladiator
Lawrence of Arabia
The Bridge on the River Kwai
Full Metal Jacket
Taps
The Great Escape
Platoon
Tora Tora Tora
The Longest Day
The Last of the Mohicans
Braveheart
Crimson Tide
The Hunt for Red October
Run Silent, Run Deep
Memphis Belle
The Guns of Navarone
The Battle of the Bulge
Twelve O'Clock High (Gregory Peck is great)
The Sands of Iwo Jima
On the Beach